Skip to content
This repository has been archived by the owner on Jul 29, 2020. It is now read-only.

Statements encapsulate #35

Merged
merged 7 commits into from
Feb 27, 2018
Merged

Statements encapsulate #35

merged 7 commits into from
Feb 27, 2018

Conversation

joelmdesouza
Copy link
Contributor

Copy link
Member

@felipeweb felipeweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these functions needs to be used in controllers. Where is the controllers’s pull request?

READ string = "read"
WRITE string = "write"
DELETE string = "delete"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All letters don’t need to be capitalized just the first letter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed permisions.go
is not used on adapters

is not used on adapters
@joelmdesouza
Copy link
Contributor Author

Sent the controllers PR @felipeweb

Copy link
Contributor

@crgimenes crgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crgimenes crgimenes merged commit ae19cf3 into prest:master Feb 27, 2018
@avelino avelino mentioned this pull request Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants